Jump to content
Piriform Community Forums
Winapp2.ini

Winapp2.ini additions

Recommended Posts

1 hour ago, siliconman01 said:

ISSUE 1 with ccinidebug:

In running the new ccinidebug, it falsely displays that every entry in the ccleaner.ini is a stale entry and will be pruned.  If I continue to the second step to let it prune and organize ccleaner.ini, it does not actually prune these entries.

 

1 hour ago, siliconman01 said:

I installed the new winapp2ool.exe and performed a TRIM.  The new TRIM removed 7 cleaning modules that should not have been removed.  In examining the ones falsely trimmed (see attached file), the "Detect" checks are all located in the HKLM\Software\WOW6432Node hive area of the registry.  So it looks like the new TRIM is not testing this area or is testing it incorrectly.

TrimmedIncorrectly.txt

I have uploaded a new version that should address these issues: https://github.com/MoscaDotTo/Winapp2/blob/master/Tools/beta/winapp2ool.exe

Share this post


Link to post
Share on other sites

TRIM worked properly except for the count discrepancy (see attached pic)

CCINIDEBUG worked properly

WINAPPDEBUG worked properly except for the count discrepancy with TRIM

DIFF worked properly.

Great progress!!! ;)

Update:  Examining CCleaner.ini file, it looks as though the count issue is in Winappdebug.exe.  This module looks like it is counting all the lines in ccleaner.ini insteard of just the (App) lines.

 

CountDiscrepancy.png

Edited by siliconman01
Added CCleaner.ini findings

Share this post


Link to post
Share on other sites
20 hours ago, siliconman01 said:

Suggested wording changes for consistency

 

WordingChanges.png

I've uploaded a new version of winapp2ool that fixes both this and the numbering issue (which was in the trim module as a result of some refactoring)

All modules have had their behavior modified, and the menus have all been tweaked to be more consistent as well :)

Share this post


Link to post
Share on other sites

When the new update, TRIM no longer works on Windows 10x64 Pro.  I get the following.

Quote

*--------------------------------------------------------------------------------------------------*
*                                             Trim                                                 *
*                                                                                                  *
*                       This tool will trim winapp2.ini down to contain only                       *
*                       entries relevant to your machine, greatly reducing both                    *
*                       application load time and the winapp2.ini filesize.                        *
*                                             Menu:                                                *
*0. Exit                - Return to the winapp2ool menu                                            *
*1. Trim (default)      - Trim winapp2.ini and save the output to a new file                       *
*2. Trim (overwrite)    - Trim winapp2.ini and overwrite the existing file                         *
*--------------------------------------------------------------------------------------------------*
Enter a number: 2
Trimming...
Trimming complete.
Initial number Of entries: 2247
Number of entries after trimming: 233
System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
   at System.ThrowHelper.ThrowKeyNotFoundException()
   at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
   at winapp2ool.trim.trim(String name)
*--------------------------------------------------------------------------------------------------*
Finished trimming winapp2.ini, press any key to return to the winapp2ool menu.
 

 

Share this post


Link to post
Share on other sites

In TRIM, I personally feel that the (default) and (overwrite) options should be swapped/changed.

1.  Trim (default)        - Trim winapp2.ini and replace the old winapp2.ini
2.  Trim (new file)       - Trim winapp2.ini and save the output to a new file

Share this post


Link to post
Share on other sites

TRIM is working now with the update that you just updated ~ 20 minutes ago. 

Thanks for the TRIM default changes.

Do LIKE the new Download file option 5.  :)

 

Share this post


Link to post
Share on other sites
1 minute ago, siliconman01 said:

TRIM is working now with the update that you just updated ~ 20 minutes ago. 

Thanks for the TRIM default changes.

Do LIKE the new Download file option 5.  :)

 

A new version uploaded only just a few minutes ago is available. It now checks for updates against the GitHub version and notifies the user in the menu when an updated winapp2ool is available. Enjoy!

Share this post


Link to post
Share on other sites
18 minutes ago, Winapp2.ini said:

A new version uploaded only just a few minutes ago is available. It now checks for updates against the GitHub version and notifies the user in the menu when an updated winapp2ool is available. Enjoy!

When I use Option 5 to download winapp2ool.exe, the download is corrupted.  See Pics

CorruptedDownload.png

ManualDownload.png

Share this post


Link to post
Share on other sites
12 minutes ago, siliconman01 said:

When I use Option 5 to download winapp2ool.exe, the download is corrupted.  See Pics

CorruptedDownload.png

ManualDownload.png

Thanks! This has been fixed, which winapp2ool will probably inform you of, but will require a manual redownload :P

Share this post


Link to post
Share on other sites
7 minutes ago, Winapp2.ini said:

Thanks! This has been fixed, which winapp2ool will probably inform you of, but will require a manual redownload :P

Fix confirmed !  :rolleyes:

Share this post


Link to post
Share on other sites

Suggestion:  An enhancement step to the Download feature 5.

Add a step that Downloads the latest winapp2.ini and Merges it with a user's file such as "Custom.ini".  Custom.ini could/would be maintained/stored in C:\Program Files\CCleaner by the user....or if it is more convenient in coding, the user could store Custom.ini in the C:\Program Files\CCleaner\winapp2ool downloads folder.

I know, I know....always wanting more :wacko::unsure::angry:...:lol:

 

Share this post


Link to post
Share on other sites
On 15.1.2018 at 23:24, SMalik said:

Thanks for checking the entries. But this would be very much work for ROCKNROLL. If the changes are important for you, I would recommend that you create your own pull request on GitHub. And as you mentioned already, you possibly overlooked a few good entries (like AMD/ATI or AVG). And I'm not sure if those changes won't start a debate if empty folder should be removed or not. :)

Share this post


Link to post
Share on other sites
1 hour ago, APMichael said:

Thanks for checking the entries. But this would be very much work for ROCKNROLL. If the changes are important for you, I would recommend that you create your own pull request on GitHub. And as you mentioned already, you possibly overlooked a few good entries (like AMD/ATI or AVG). And I'm not sure if those changes won't start a debate if empty folder should be removed or not. :)

These changes are not only important for me, these are VERY important for anyone who uses Winapp2.ini file.

Share this post


Link to post
Share on other sites
3 hours ago, SMalik said:

These changes are not only important for me, these are VERY important for anyone who uses Winapp2.ini file.

I fully understand your concerns. But to be honest, removing an empty folder usually doesn't break anything. There are no reports here that one of those (partially very old) entries causing trouble. If you create a pull request on GitHub I'm sure they will merge it.

Share this post


Link to post
Share on other sites
1 hour ago, APMichael said:
5 hours ago, SMalik said:

These changes are not only important for me, these are VERY important for anyone who uses Winapp2.ini file.

I fully understand your concerns. But to be honest, removing an empty folder usually doesn't break anything. There are no reports here that one of those (partially very old) entries causing trouble. If you create a pull request on GitHub I'm sure they will merge it.

I thank you for your concerned about keeping users safe with Winapp2. Some of the entries you have pointed out have been in Winapp2 for a long time now, and so far no one has been reporting any issues with them. If a program is breaking due to this, I will gladly fix it for you. Ultimately, both the software and Windows are very good at restoring folders needed, since they are designed to restore the lost folder if needed, and this has been the case since XP came out.

If it makes you feel any better, during the 2nd overhaul, we did already remove dangerous REMOVESELFs from Winapp2 entries and kept the ones that don't put anyone at risk.

Share this post


Link to post
Share on other sites
12 hours ago, ROCKNROLL said:

I thank you for your concerned about keeping users safe with Winapp2. Some of the entries you have pointed out have been in Winapp2 for a long time now, and so far no one has been reporting any issues with them. If a program is breaking due to this, I will gladly fix it for you. Ultimately, both the software and Windows are very good at restoring folders needed, since they are designed to restore the lost folder if needed, and this has been the case since XP came out.

If it makes you feel any better, during the 2nd overhaul, we did already remove dangerous REMOVESELFs from Winapp2 entries and kept the ones that don't put anyone at risk.

Program folders are not junk. We cannot remove program folders on the basis that they will get re-created on demand. Removing program folders do not break programs is not an acceptable argument.

Share this post


Link to post
Share on other sites
3 hours ago, SMalik said:

Program folders are not junk. We cannot remove program folders on the basis that they will get re-created on demand. Removing program folders do not break programs is not an acceptable argument.

 

Here is my 2 cents about this pointless discussion (just my opinion).
How long has winapp2 been out in the wild ?
How many users are using it ?


I  am no smart man but I am 100% sure a lot of people/developers using winapp2 or a spinoff of it would have complained IF an entry using REMOVESELF "break" their software.
I for one, am not fond of seeing empty folders on my systems. Using REMOVESELF makes my life a bit more ordered.
 
Besides, who runs CCleaner anyway with software running (Excluding AVs and active malware software) ?

Share this post


Link to post
Share on other sites

Question:

I found under the folder "%LocalAppData%\Packages\Microsoft.Windows.ShellExperienceHost_cw5n1h2txyewy\AC\Microsoft\Windows" tons of subfolders named with a random number. Each subfolder contains a single .pri file named with a random number also.

("Microsoft.LockApp_cw5n1h2txyewy" and "Microsoft.Windows.Cortana_cw5n1h2txyewy" contains those subfolders/files also.)

Does anybody know if those .pri files are necessary or what function they have?

Share this post


Link to post
Share on other sites

New Entry

[Lenovo System Update *]
LangSecRef=3024
DetectFile=%CommonAppData%\Lenovo\SystemUpdate\sessionSE\Repository
Default=False
FileKey1=%CommonAppData%\Lenovo\SystemUpdate\sessionSE\Repository|*.*|RECURSE
FileKey2=%CommonAppData%\Lenovo\SystemUpdate\sessionSE\system\SSClientCommon|*.xml

Share this post


Link to post
Share on other sites
6 hours ago, APMichael said:

Question:

I found under the folder "%LocalAppData%\Packages\Microsoft.Windows.ShellExperienceHost_cw5n1h2txyewy\AC\Microsoft\Windows" tons of subfolders named with a random number. Each subfolder contains a single .pri file named with a random number also.

("Microsoft.LockApp_cw5n1h2txyewy" and "Microsoft.Windows.Cortana_cw5n1h2txyewy" contains those subfolders/files also.)

Does anybody know if those .pri files are necessary or what function they have?

I think this link explains what the *.PRI files are:

https://docs.microsoft.com/en-us/windows/uwp/app-resources/resource-management-system

Share this post


Link to post
Share on other sites
9 hours ago, Hav0c said:

 

Here is my 2 cents about this pointless discussion (just my opinion).
How long has winapp2 been out in the wild ?
How many users are using it ?


I  am no smart man but I am 100% sure a lot of people/developers using winapp2 or a spinoff of it would have complained IF an entry using REMOVESELF "break" their software.
I for one, am not fond of seeing empty folders on my systems. Using REMOVESELF makes my life a bit more ordered.
 
Besides, who runs CCleaner anyway with software running (Excluding AVs and active malware software) ?

Since we are getting mixed opinions on this, maybe a better solution would be to make Winapp2ool pick out all the entries with RECURSE and REMOVESELF and then have a way for the user to switch them. This way, if a user doesn't feel a entry with REMOVESELF is safe, they can use the tool and switch it to RECURSE and switch RECURSE to REMOVESELF if they don't want a pile up of empty folders.

Share this post


Link to post
Share on other sites
1 hour ago, ROCKNROLL said:

Since we are getting mixed opinions on this, maybe a better solution would be to make Winapp2ool pick out all the entries with RECURSE and REMOVESELF and then have a way for the user to switch them. This way, if a user doesn't feel a entry with REMOVESELF is safe, they can use the tool and switch it to RECURSE and switch RECURSE to REMOVESELF if they don't want a pile up of empty folders.

 

Do not get me wrong Winapp2ool has the potential to be a great tool.
But (like in all cases there is a but) let the developer  get a sold base line of functions out before asking a lot of functions from the get go.

Some functions within the tool as of now is "nice to have" in my opinion. Could have left it for later versions of the application.

Allso does not help the developer is rushing things and have to release a new "bug free" version every couple of hours due to something that broke while adding new function.

Baby steps.....

Share this post


Link to post
Share on other sites
4 hours ago, Hav0c said:

 

Do not get me wrong Winapp2ool has the potential to be a great tool.
But (like in all cases there is a but) let the developer  get a sold base line of functions out before asking a lot of functions from the get go.

Some functions within the tool as of now is "nice to have" in my opinion. Could have left it for later versions of the application.

Allso does not help the developer is rushing things and have to release a new "bug free" version every couple of hours due to something that broke while adding new function.

Baby steps.....

Sorry about the rushed nature of the builds ;) I had about 4 days from start-to-finish before I would (as I am currently) become busy with some school business, probably for the next week or so, so I wanted to get down what I could while the concepts were still somewhat fresh in my mind.

WRT REMOVESELF

 

I think this should only be used in instances like cache folders, where deleting the folders goes hand-in-hand with deleting their contents. Empty folders aren't necessarily junk or a privacy concern.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×